Feature/add sync #173
Merged
Feature/add sync #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
River-sh
commented
Jun 3, 2024
River-sh
commented
- bugfix: fix vpn link and rule leak
- add regular sync raven rules
River-sh
force-pushed
the
feature/add_sync
branch
11 times, most recently
from
e7bca45
to
08f10a8
Compare
River-sh
force-pushed
the
feature/add_sync
branch
from
08f10a8
to
4b482fc
Compare
…tain the current VPN link status, and compare the expected status with the current status for configuration. (Wireguard has the same principle) 2. Add a regular synchronization mechanism
River-sh
force-pushed
the
feature/add_sync
branch
from
4b482fc
to
1f91e43
Compare
YTGhost
reviewed
Jun 10, 2024
Comment on lines
-1
to
-41
| /* | ||
| Copyright 2023 The OpenYurt Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package utils | ||
|
|
||
| import ( | ||
| "fmt" | ||
| ) | ||
|
|
||
| func FormatProxyServer(format string, args ...interface{}) string { | ||
| s := fmt.Sprintf(format, args...) | ||
| return fmt.Sprintf("[Proxy Server]: %s", s) | ||
| } | ||
|
|
||
| func FormatProxyClient(format string, args ...interface{}) string { | ||
| s := fmt.Sprintf(format, args...) | ||
| return fmt.Sprintf("[Proxy Client]: %s", s) | ||
| } | ||
|
|
||
| func FormatTunnel(format string, args ...interface{}) string { | ||
| s := fmt.Sprintf(format, args...) | ||
| return fmt.Sprintf("[Tunnel Agent]: %s", s) | ||
| } | ||
|
|
||
| func FormatRavenEngine(format string, args ...interface{}) string { | ||
| s := fmt.Sprintf(format, args...) | ||
| return fmt.Sprintf("[Raven Engine]: %s", s) | ||
| } |
There was a problem hiding this comment.
Why was the format method removed here?
There was a problem hiding this comment.
This does not seem to be necessary, some lib logs do not have this mark
Comment on lines
+576
to
+581
| time.Sleep(time.Second) | ||
| err = vx.ipset.Flush() | ||
| if err != nil { | ||
| errList = errList.Append(fmt.Errorf("error flushing ipset: %s", err)) | ||
| } | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
This is necessary, using the tool quickly may cause the tool to return an unnecessary error message when it is busy.
| @@ -0,0 +1,129 @@ | |||
| /* | |||
| Copyright 2023 The OpenYurt Authors. | |||
Comment on lines
+560
to
+563
| err = vpndriveripset.CleanupRavenSkipNATIPSet() | ||
| if err != nil { | ||
| errList = errList.Append(fmt.Errorf("error cleanup ipset %s, %s", vpndriveripset.RavenSkipNatSet, err.Error())) | ||
| } |
There was a problem hiding this comment.
Do we need to check here whether the node is a Gateway?
There was a problem hiding this comment.
When cleaning is needed, it is impossible to determine whether it is a gateway
njucjc
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.